[Identity] upgrade the msal dependencies due to security issue in jsonwebtoken #24458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken library, which is a dependency of msal-node
KarishmaGhiya
requested review from
praveenkuttappan,
witemple-msft,
deyaaeldeen,
jeremymeng and
schaabs
as code owners
ghost
added
the
|
Could you please merge latest main here? I don't expect changes in our lockfile. |
|
Also, could you update the changelog? |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run js - identity - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KarishmaGhiya
commented
Jan 12, 2023
deyaaeldeen
reviewed
Jan 12, 2023
deyaaeldeen
reviewed
Jan 12, 2023
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
KarishmaGhiya
added a commit
that referenced
this pull request
Feb 9, 2023
KarishmaGhiya
added a commit
that referenced
this pull request
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
There's a CVE associated with this for jsonwebtoken vulnerability- https://nvd.nist.gov/vuln/detail/CVE-2022-23529
Describe the problem that is addressed by this PR
Upgrading the msal dependencies due to security issue in Auth0's jsonwebtoken library, which is a dependency of msal-node. The latest versions of msal libraries depend on the fix released by jsonwebtoken library version 9.0.0
Checklists